Home Explore Help
Sign In
matteozeccolimarazzini
/
vaporget
2
0
Fork 0
Files Issues 3 Pull Requests 1 Wiki
Labels Milestones
New Pull Request

#15 Add `vaporget` Logo

Open
matteosavatteri wants to merge 6 commits from matteozeccolimarazzini/logo into matteozeccolimarazzini/master
Conversation 3 Commits 6 Files changed 3
Matteo Savatteri commented 4 years ago

This pr adds a simple vaporget ASCII text logo to our version information text and README (cccecd8fb3, bbcec12009). It also specifies the licence of this logo (4672dc3d20) and adds GPLv3 and CC by 4.0 licenses logos to the README (78c8fd3ad4).

This pr adds a simple `vaporget` ASCII text logo to our version information text and `README` (cccecd8fb3, bbcec12009). It also specifies the licence of this logo (4672dc3d20) and adds `GPLv3` and `CC by 4.0` licenses logos to the `README` (78c8fd3ad4).
Matteo Zeccoli Marazzini commented 4 years ago
Owner

I think it would be nice to have a colored logo. Since not every terminal supports the same number of colors, I have created three different variables for monochrome, 8 colors and 256 colors. I haven't added the actual colors yet, so for now they all look the same. The check for the number of colors is done using tput, which should already be installed because we use dialog and clear, both of which use ncurses.

I think it would be nice to have a colored logo. Since not every terminal supports the same number of colors, I have created three different variables for monochrome, 8 colors and 256 colors. I haven't added the actual colors yet, so for now they all look the same. The check for the number of colors is done using `tput`, which should already be installed because we use `dialog` and `clear`, both of which use `ncurses`.
Matteo Zeccoli Marazzini commented 4 years ago
Owner

I've rebased this on the current master (I hope everything went well). Now we only need to color the logo haha.

I've rebased this on the current master (I hope everything went well). Now we only need to color the logo haha.
Matteo Zeccoli Marazzini commented 4 years ago
Owner

I have committed a draft for the 8 color version of the logo. I think that the best thing to do is to have a commit where we add the 8-color logo and a commit for the 256-color one; therefore I suggest amending the current commit and force-pushing until we are satisfied, and then doing it again for the 256-color one.

I think that purple is a good, vaporwave-ish color, but if you @matteosavatteri have different preferences let me know.

I have committed a draft for the 8 color version of the logo. I think that the best thing to do is to have a commit where we add the 8-color logo and a commit for the 256-color one; therefore I suggest amending the current commit and force-pushing until we are satisfied, and then doing it again for the 256-color one. I think that purple is a good, vaporwave-ish color, but if you @matteosavatteri have different preferences let me know.
This pull request can be merged automatically.
Sign in to join this conversation.
Labels
Clear labels
bug duplicate enhancement help wanted invalid question wontfix
No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No Milestone
Assignee
Clear assignee
No assignee
2 Participants
Write Preview
Loading...
Cancel
Save
There is no content yet.